Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.systemd: port to Python #78241

Merged
merged 1 commit into from
Jan 30, 2020
Merged

nixosTests.systemd: port to Python #78241

merged 1 commit into from
Jan 30, 2020

Conversation

andrew-d
Copy link
Contributor

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc @aszlig @flokli @abbradar

@andrew-d andrew-d force-pushed the andrew/systemd-tests-python branch from 64f8b3a to a8bf90b Compare January 22, 2020 06:04
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 22, 2020
@mmahut
Copy link
Member

mmahut commented Jan 22, 2020

@GrahamcOfBorg test systemd

flokli
flokli reviewed Jan 22, 2020
View reviewed changes
@andrew-d andrew-d force-pushed the andrew/systemd-tests-python branch from a8bf90b to 2c9bff9 Compare January 23, 2020 00:11
@andrew-d
Copy link
Contributor Author

@flokli - Thanks for the review - made those changes, along with a few more cleanups.

@andrew-d andrew-d requested a review from flokli January 23, 2020 00:12
@tfc tfc mentioned this pull request Jan 25, 2020
Closed
@andrew-d
Copy link
Contributor Author

@flokli - And a ping on this one as well!

@tfc
Copy link
Contributor

tfc commented Jan 30, 2020

cc @worldofpeace

@andrew-d
Copy link
Contributor Author

@GrahamcOfBorg build nixosTests.systemd

@worldofpeace
Copy link
Contributor

Merging as is, because it was broken before https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.systemd.x86_64-linux

@worldofpeace worldofpeace merged commit b46a1b5 into NixOS:master Jan 30, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#78241 from andrew-d/andrew/systemd-tests-python
1f746af 
nixosTests.systemd: port to Python
@andrew-d andrew-d deleted the andrew/systemd-tests-python branch March 29, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrew-d @mmahut @tfc @worldofpeace @flokli